Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in some comments #5196

Closed
wants to merge 1 commit into from
Closed

docs: fix typos in some comments #5196

wants to merge 1 commit into from

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Mar 3, 2024 •
edited
Loading

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@jxs jxs changed the title fix some comments docs: fix typos in some comments Mar 3, 2024
jxs
jxs approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM can you just accept the suggestion? I don't seem to have permissions to commit it

core/src/transport.rs Outdated Show resolved Hide resolved
@cuishuang
docs: fix typos in some comments
1541ee0 
Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang
Copy link
Contributor Author

Modified, please check again

@jxs jxs added the send-it label Mar 4, 2024
@drHuangMHT
Copy link
Contributor

@jxs Still cannot merge after labeled send-it 🙏

@jxs
Copy link
Member

jxs commented Mar 11, 2024

thanks for the ping @drHuangMHT it seems the permissions don't allow to merge:

'Require a pull request before merging' branch protections are enabled on master, Mergify cannot check the pull request inplace.

can you change this @cuishuang ?
thanks

@cuishuang
Copy link
Contributor Author

'Require a pull request before merging' branch protections are enabled on master, Mergify cannot check the pull request inplace.

Thanks! Of course.

But how should I operate?

@jxs
Copy link
Member

jxs commented Mar 12, 2024

see here

@cuishuang
Copy link
Contributor Author

see here

image

Thank you. But the option I see in the bottom right corner is not available for selection

@jxs
Copy link
Member

jxs commented Mar 13, 2024

ah, it might be because you don't have those permissions over rustaceanclub/libp2p can you submit the PR from a fork owned by you?

@cuishuang
Copy link
Contributor Author

ah, it might be because you don't have those permissions over rustaceanclub/libp2p can you submit the PR from a fork owned by you?

This is the organization I created so there are absolute permissions.

I did something in the settings, please try again

@cuishuang
Copy link
Contributor Author

image something like this

@jxs
Copy link
Member

jxs commented Mar 13, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

refresh

✅ Pull request refreshed

@jxs
Copy link
Member

jxs commented Mar 14, 2024

@cuishuang seems to still have not be solved sorry

@cuishuang
Copy link
Contributor Author

@cuishuang seems to still have not be solved sorry

It's okay, sorry for wasting your precious time. I'll try to pull and submit it again~

@cuishuang cuishuang mentioned this pull request Mar 24, 2024
Merged
4 tasks
@cuishuang
Copy link
Contributor Author

@cuishuang seems to still have not be solved sorry
Hi, I have resubmitted an MR, please review it again.
#5255

@cuishuang cuishuang closed this Mar 24, 2024
mergify bot pushed a commit that referenced this pull request Mar 25, 2024
@cuishuang
docs: fix typos in some comments
b890b29 
The same as #5196

There are some problem when merging #5196, resubmit this mr.

Pull-Request: #5255.
guillaumemichel pushed a commit that referenced this pull request Mar 28, 2024
@cuishuang @guillaumemichel
docs: fix typos in some comments
b8b157a 
The same as #5196

There are some problem when merging #5196, resubmit this mr.

Pull-Request: #5255.
umgefahren pushed a commit to p2p-industries/rust-libp2p that referenced this pull request May 20, 2024
@cuishuang
docs: fix typos in some comments
887cf3c 
The same as libp2p#5196

There are some problem when merging libp2p#5196, resubmit this mr.

Pull-Request: libp2p#5255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuishuang @drHuangMHT @jxs